Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link prop is required in ShareModal but it is not always available #1335

Open
Ldoppea opened this issue Aug 9, 2021 · 0 comments
Open

Link prop is required in ShareModal but it is not always available #1335

Ldoppea opened this issue Aug 9, 2021 · 0 comments
Labels
cozy-sharing

Comments

@Ldoppea
Copy link
Member

Ldoppea commented Aug 9, 2021

When sharing a document in cozy-drive, link does not exist until generate link is clicked.
When sharing a password in cozy-pass-web, we deactivate the share by link capability.

Regarding those points, Link shouldn't be set as required by PropTypes :

cozy-libs/packages/cozy-sharing/src/components/ShareModal.jsx

Line 95 in 9f463ef

link: PropTypes.string.isRequired,

Do you agree with that conclusion?
@Ldoppea Ldoppea changed the title Link prop is required in ShareModal but it is not always available Link prop is required in ShareModal but it is not always available Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cozy-sharing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ldoppea