Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LWG 1] P3504R0 C++ Standard Library Ready Issues #7459

Merged
merged 35 commits into from
Dec 16, 2024
Merged

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 28, 2024

Fixes #7413.

Notes: I assumed the Tentatively Ready issues were to be applied also.

Fixes cplusplus/papers#2165
Also fixes cplusplus/papers#1983
Also fixes cplusplus/papers#1811
Also fixes cplusplus/papers#1814

@burblebee burblebee marked this pull request as ready for review November 28, 2024 11:43
@jwakely
Copy link
Member

jwakely commented Nov 28, 2024

Notes: I assumed the Tentatively Ready issues were to be applied also.

Yes: "Apply the changes for all Ready and Tentatively Ready issues in P3504R0 (C++ Standard Library Ready Issues to be moved in Wrocław, Nov. 2024) to the C++ working paper."

@jensmaurer jensmaurer added this to the post-2024-11 milestone Dec 4, 2024
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 13, 2024
@@ -9261,8 +9261,6 @@

// bit reference
class @\libmember{reference}{vector<bool>}@ {
constexpr reference() noexcept;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, the friend declarations were removed by #6427

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, appreciated!

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move two occurrences of "only" to later in the sentence, for more goodly Englishing.

Change address to to_address.

Use \libconcept for same_as, twice

@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from 7820989 to 6b52bff Compare December 16, 2024 02:27
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now added suggestions for the remaining issues. Those could be committed directly to the branch, or squashed individually to the relevant commits.

@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch 2 times, most recently from 0898ed1 to 3a057d4 Compare December 16, 2024 12:21
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from 3a057d4 to af41385 Compare December 16, 2024 12:36
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from af41385 to 20aa7ce Compare December 16, 2024 12:45
[optional.assign] Removed "<T>" from declaration to match that in synopsis.
[template.bitset.general] [vector.bool.pspc] bitset already removed.
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from 20aa7ce to 5ce6b99 Compare December 16, 2024 12:56
@tkoeppe tkoeppe force-pushed the motions-2024-11-lwg-1 branch from 5ce6b99 to 71389a0 Compare December 16, 2024 17:21
@tkoeppe tkoeppe merged commit 6d81ed8 into main Dec 16, 2024
4 checks passed
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 16, 2024
@jensmaurer jensmaurer deleted the motions-2024-11-lwg-1 branch February 15, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment