Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-11 CWG Motion 8] P3176R1 The Oxford variadic comma #7434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[2024-11 CWG Motion 8] P3176R1 The Oxford variadic comma #7434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions source/declarations.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3602,8 +3602,10 @@
\indextext{declaration!function}%
\begin{bnf}
\nontermdef{parameter-declaration-clause}\br
\opt{parameter-declaration-list} \opt{\terminal{...}}\br
parameter-declaration-list \terminal{,} \terminal{...}
\terminal{...}\br
\opt{parameter-declaration-list}\br
parameter-declaration-list \terminal{,} \terminal{...}\br
parameter-declaration-list \terminal{...}
\end{bnf}

\begin{bnf}
Expand Down Expand Up @@ -3659,9 +3661,13 @@
argument and are not function parameter packs.
Where syntactically correct and where ``\tcode{...}'' is not
part of an \grammarterm{abstract-declarator},
``\tcode{, ...}''
``\tcode{...}''
is synonymous with
``\tcode{...}''.
``\tcode{, ...}''.
A \grammarterm{parameter-declaration-clause}
of the form
\grammarterm{parameter-declaration-list} \tcode{...}
is deprecated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a iref to [depr.ellipsis.comma]?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually do that on this PR? I have been told that any editorial fixes that would change the approved wording should be done as a separate follow-up PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a separate commit in the same pull request,
maybe with the title "[section.label] Add cross-reference to [xyz.abc]"
or so.

This way, we clearly separate the approved wording from the paper from add-on editorial fixes.

\begin{example}
The declaration
\begin{codeblock}
Expand Down
13 changes: 13 additions & 0 deletions source/future.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,19 @@
\end{codeblock}
\end{example}

\rSec1[depr.ellipsis.comma]{Non-comma-separated ellipsis parameters}

A \grammarterm{parameter-declaration-clause}
of the form
\grammarterm{parameter-declaration-list} \tcode{...}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, I think this should have an iref back to [dcl.fct] (I think that is the right clause)

is deprecated.
\begin{example}
\begin{codeblock}
void f(int...); // deprecated
void g(auto...); // OK, declares a function parameter pack
void h(auto......); // deprecated
\end{codeblock}
\end{example}

\rSec1[depr.array.comp]{Array comparisons}

Expand Down
Loading