fixes for codacy

cpv-project · Oct 21, 2019 · 387e4bb · 387e4bb
1 parent 5c1e73c
commit 387e4bb
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/include/CPVFramework/Container/ServiceFactory.hpp b/include/CPVFramework/Container/ServiceFactory.hpp
@@ -73,7 +73,7 @@ namespace cpv {
 		}
 
 		/** Constructor **/
-		ServiceDependencyInjectionFactory(Container& container) :
+		explicit ServiceDependencyInjectionFactory(Container& container) :
 			dependencyDescriptors_(Extensions::getDependencyDescriptors(container)) { }
 
 	private:
@@ -110,7 +110,7 @@ namespace cpv {
 		}
 
 		/** Constructor **/
-		ServiceDependencyInjectionFactory(Container& container) :
+		explicit ServiceDependencyInjectionFactory(Container& container) :
 			dependencyDescriptors_(Extensions::getDependencyDescriptors(container)) { }
 
 	private:

diff --git a/include/CPVFramework/HttpServer/HttpContext.hpp b/include/CPVFramework/HttpServer/HttpContext.hpp
@@ -63,7 +63,7 @@ namespace cpv {
 			serviceStorage_() { }
 
 		/** Constructor for null context, should set members later */
-		HttpContext(nullptr_t) :
+		explicit HttpContext(nullptr_t) :
 			request_(nullptr),
 			response_(nullptr),
 			clientAddress_(),

diff --git a/include/CPVFramework/HttpServer/HttpServer.hpp b/include/CPVFramework/HttpServer/HttpServer.hpp
@@ -37,7 +37,7 @@ namespace cpv {
 		 *	The last handler must not call the next handler, there is a real last handler
 		 *		but only returns exception future.
 		 */
-		HttpServer(const Container& container);
+		explicit HttpServer(const Container& container);
 
 		/** Move constructor (for incomplete member type) */
 		HttpServer(HttpServer&&);

diff --git a/include/CPVFramework/Utility/Packet.hpp b/include/CPVFramework/Utility/Packet.hpp
@@ -48,7 +48,7 @@ namespace cpv {
 			}
 
 			SingleFragment() : fragment(), deleter() { }
-			SingleFragment(const seastar::net::fragment& fragmentVal) :
+			explicit SingleFragment(const seastar::net::fragment& fragmentVal) :
 				fragment(fragmentVal), deleter() { }
 			SingleFragment(const seastar::net::fragment& fragmentVal, seastar::deleter&& deleterVal) :
 				fragment(fragmentVal), deleter(std::move(deleterVal)) { }

diff --git a/tests/Cases/Container/TestContainer.cpp b/tests/Cases/Container/TestContainer.cpp
@@ -480,7 +480,7 @@ TEST(TestContainer, patchDoesNotBreakDIFactory) {
 	container.add<std::unique_ptr<int>>([] { return nullptr; });
 	container.add<std::unique_ptr<int>>([] { return std::make_unique<int>(101); });
 	cpv::ServicePatcher<std::string>::patch(
-		container, [] (std::string v) { return v + ".patched"; });
+		container, [] (const std::string& v) { return v + ".patched"; });
 	cpv::ServicePatcher<std::unique_ptr<int>>::patch(
 		container, [] (std::unique_ptr<int> v) {
 			if (v != nullptr) {