Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference tree structure declaration #11

Merged
merged 20 commits into from
Feb 2, 2024
Merged

Conversation

kniazkov
Copy link
Member

Subj.

@kniazkov kniazkov requested a review from pollyvolk January 26, 2024 09:11
@kniazkov kniazkov self-assigned this Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (779d8ae) 82.08% compared to head (13fa933) 82.38%.
Report is 3 commits behind head on master.

Files Patch % Lines
...n/java/org/cqfn/astranaut/core/DifferenceNode.java 77.41% 5 Missing and 9 partials ⚠️
src/main/java/org/cqfn/astranaut/core/Delete.java 71.79% 7 Missing and 4 partials ⚠️
src/main/java/org/cqfn/astranaut/core/Node.java 84.61% 0 Missing and 2 partials ⚠️
...tranaut/core/algorithms/DifferenceTreeBuilder.java 90.00% 0 Missing and 2 partials ⚠️
...rg/cqfn/astranaut/core/utils/JsonDeserializer.java 50.00% 1 Missing and 1 partial ⚠️
...ranaut/core/utils/deserializer/NodeDescriptor.java 91.66% 0 Missing and 2 partials ⚠️
...ranaut/core/utils/deserializer/TreeDescriptor.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
+ Coverage     82.08%   82.38%   +0.30%     
- Complexity      139      191      +52     
============================================
  Files            22       28       +6     
  Lines           586      738     +152     
  Branches         87      111      +24     
============================================
+ Hits            481      608     +127     
- Misses           78       90      +12     
- Partials         27       40      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kniazkov kniazkov marked this pull request as ready for review February 2, 2024 09:36
@kniazkov kniazkov changed the title Porting the functionality of difference tree building Difference tree structure declaration Feb 2, 2024
@kniazkov
Copy link
Member Author

kniazkov commented Feb 2, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 2, 2024

@rultor merge

@kniazkov OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 33f1a4b into cqfn:master Feb 2, 2024
3 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 2, 2024

@rultor merge

@kniazkov Done! FYI, the full log is here (took me 4min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants