Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstallTrigger to detect Firefox is deprecated #690

Open
BenTen opened this issue Sep 1, 2023 · 0 comments
Open

InstallTrigger to detect Firefox is deprecated #690

BenTen opened this issue Sep 1, 2023 · 0 comments

Comments

@BenTen
Copy link

BenTen commented Sep 1, 2023

To detect Firefox, Print.js use InstallTrigger but it's deprecated.

Here https://bugzilla.mozilla.org/show_bug.cgi?id=1754441#c30 Dennis Schubert said

If no feature detection is possible, I agree that this is a bit of a bad spot to be in. In those cases, running the simplest user-agent based test, something like
const isFirefox = /firefox/i.test(navigator.userAgent);
is probably the best way here.

Relying on Firefox-only properties to detect the browser itself might look like an easier solution, but unfortunately it has the potential of breaking down the line - or it can force the browser developers to keep a non-standard property around just for compatibility reasons, which also isn't great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant