Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: New products/variants are not promotable by default #3571

Closed
mikesnoeren opened this issue Jul 9, 2024 · 4 comments
Closed

[5.x]: New products/variants are not promotable by default #3571

mikesnoeren opened this issue Jul 9, 2024 · 4 comments

Comments

@mikesnoeren
Copy link

What happened?

Description

As per the documentation, the promotable option should be enabled by default. In Craft 5 + Commerce 5 this is not the case.

Steps to reproduce

1.Make a product
2.See see the lightswitch is not flipped by default.

Craft CMS version

5.2.5

Craft Commerce version

5.0.11.1

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

Copy link

linear bot commented Jul 9, 2024

@nfourtythree
Copy link
Contributor

Hi @mikesnoeren

Thank you for reporting this. We have made an issue in the docs to be updated to make sure they explain how the system is working.

We have also added the promotable property to the options for showing in the variant index. This will allow you to have better visibility over which variants have been set to be profitable. This change will be included in the next release of Commerce.

We will take the feedback on board and see if there is a way (maybe a setting) to change the behaviour for whether a new variant is promotable by default.

Thanks!

@mikesnoeren
Copy link
Author

Hi @nfourtythree, thanks for creating the issue in the docs.

From my perspective, enabling the promotable property by default would be the most effective approach. Any necessary (conditional) rules for promotions should, in my opinion, be managed within the promotion itself.

Introducing this setting seems to add unnecessary complexity to the already intricate promotions functionality.

Additionally, I find it quite unconventional to restrict certain products from being eligible for promotions. Having worked on multiple webshops, we have never encountered a need for this restriction.

nfourtythree added a commit that referenced this issue Jul 11, 2024
…svariants-are-not-promotable-by-default

Add `promotable` column to variant element indexes  #3571
@nfourtythree
Copy link
Contributor

Hi @mikesnoeren

Again, thank you for this feedback. We will take it on board when making decisions regarding this functionality.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants