From 16571ee0cdae406659b11b80baf9bcd3d1eeabc8 Mon Sep 17 00:00:00 2001
From: Dominick Johnson <dominick.johnson@tylertech.com>
Date: Wed, 17 Jan 2024 09:54:13 -0700
Subject: [PATCH] Fix 2 bugs: * PHP 8 no longer considers '' equal to 0,
 breaking edit_entry.php * Deleted users can still be assigned to groups,
 breaking groups page

---
 includes/functions.php | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/includes/functions.php b/includes/functions.php
index 0c734a68b..21345ace2 100644
--- a/includes/functions.php
+++ b/includes/functions.php
@@ -802,7 +802,7 @@ function date_selection($prefix, $date, $trigger = false, $num_years = 20)
  * @return int  Timestamp representing, in UTC or LOCAL time.
  */
 function date_to_epoch( $d, $gmt = true ) {
-  if ( $d == 0 )
+  if ( $d == 0 || $d === '' )
     return 0;
 
   $dH = $di = $ds = 0;
@@ -2596,7 +2596,13 @@ function get_groups($user, $includeUserlist=false)
       $sql = 'SELECT cal_login FROM webcal_group_user WHERE cal_group_id = ? ORDER BY cal_login';
       $res = dbi_execute($sql, [$groups[$i]['cal_group_id']]);
       while ($row = dbi_fetch_row($res)) {
-        $users[] = $users_by_name[$row[0]];
+        if (isset($users_by_name[$row[0]])){
+            // It is possible some users assigned to this group may not exist, 
+            // so we skip those that don't. For example, if users are fetched 
+            // from an external source via user-app-*.php, and one of those 
+            // users is deleted externally.
+            $users[] = $users_by_name[$row[0]];
+        }
       }
       $groups[$i]['cal_users'] = $users;
     }