Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probable solution for touchscreens #163

Closed
janvanl opened this issue Aug 15, 2019 · 8 comments
Closed

probable solution for touchscreens #163

janvanl opened this issue Aug 15, 2019 · 8 comments

Comments

@janvanl
Copy link

janvanl commented Aug 15, 2019

Hi,
I found
https://www.jqueryscript.net/other/jQuery-Plugin-For-Double-Click-Tap-Detection-doubleTap.html

You use dblclick_add.js

I will try if it helps changing to the jquery plugin.

Regards,
Jan

@janvanl
Copy link
Author

janvanl commented Feb 8, 2020

Hi,

I have placed a + (plussign) as a link again.

in includes/functions.php
at about line 4606

just after
substr ( $date, 6, 2 ) . '</a>
add
<span style="float:right"><a href="edit_entry.php?date='.$date.'" title="Einzelklick fügt einen neuen Termin ein."><b><u>[&nbsp;+&nbsp;]</u></b></a>&nbsp;&nbsp;&nbsp;&nbsp;</span>

In the month-view you will see a link [ + ] if you click or tap on it a new entry can be made.

Regards,
Jan

@john-mcdermott
Copy link

john-mcdermott commented Feb 27, 2020

Hello Jan. Would you mind providing a bit more detail on this. I have added the code as you directed but it just ends up stop the webcalendar from loading.

This is where I have placed your code as instructed...

Capture

Have I done something wrong? With the addition of the code again the webcal simply doesn't load...

Any help is very much appreciated!!! Much Thanks, John

@janvanl
Copy link
Author

janvanl commented Feb 27, 2020

I will copy a bigger part of the code.
Must look up where I have it.

@janvanl
Copy link
Author

janvanl commented Feb 27, 2020

Hi,
this is the code from line 4592 to 4610.

 if ( ! $ssi ) {
  /* translate ( 'First Quarter Moon') translate ( 'Full Moon' )
     translate ( 'Last Quarter Moon') translate ( 'New Moon' )
   */
    $userCatStr = ( strcmp ( $user, $login ) ? 'user=' . $user . '&amp;' : '' )
     . ( empty ( $cat_id ) ? '' : 'cat_id=' . $cat_id . '&amp;' );
    $tmp = ( empty( $moons[$date] ) ? '' : $moons[$date] );
    $moon_title = ( empty ( $tmp ) ? '' : translate ( ucfirst ( $tmp )
     . ( strpos ( 'fullnew', $tmp ) !== false ? '' : ' Quarter' ) . ' Moon' ) );
    $ret = ( $can_add ? '
        <a title="' . $newEntryStr . '" href="edit_entry.php?' . $userCatStr
       . 'date=' . $date . '"><img src="images/new.gif" alt="' . $newEntryStr
       . '" class="new" /></a>' : '' ) . '
        <a class="dayofmonth" href="day.php?' . $userCatStr . 'date=' . $date
     . '">' . substr ( $date, 6, 2 ) . '</a><span style="float:right"><a href="edit_entry.php?date='.$date.'" title="Einzelklick fügt einen neuen Termin ein."><b><u>[&nbsp;+&nbsp;]</u></b></a>&nbsp;&nbsp;&nbsp;&nbsp;</span>' . ( empty ( $tmp )
      ? '' : '<img src="images/' . $tmp . 'moon.gif" title="' . $moon_title
      . '" alt="' . $moon_title . '" />' ) . "<br />\n";
    $cnt++;
  }

It is working in my calendar and that of the customer.
Mind the quotes. Seems you made a mistake there.

Regards,
Jan

@john-mcdermott
Copy link

john-mcdermott commented Feb 28, 2020 via email

@john-mcdermott
Copy link

john-mcdermott commented Feb 28, 2020 via email

@adam12b1
Copy link

Note that there is a setting, stored as ADD_LINK_IN_VIEWS in the webcal_config database table, that is supposed to bring back the + links and would thus solve this issue within Webcalendar, but it appears to be broken. Just filed bug #220.

@craigk5n
Copy link
Owner

In regard to the comment from @adam12b1 above, that is not what ADD_LINK_IN_VIEWS is used for. That option enables/disables the ability to add (via double click) events from any of the custom view pages (view_m.php, view_w.php, etc.). Without this option being enabled, users need to go to a standard view (month.php, week.php, etc.) to add an event with the double click. It may be worth adding better help text for that option to better describe this feature.

Otherwise, this issue is a duplicate of #140, so I am closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants