chore: investigate ci linter issues (#67)

* Empty commit for diff

* chore: update ci lint version

* chore: switch to golangcilint action

* chore: update to v6 version of golangcilint

* chore: disable mnd

* chore: remove deprecated and deactivated linters

* chore: disable depguard

* chore: update to go 1.22

* chore: disable testifylint

* chore: goerr13 has been renamed in the linter database

* chore: update go versions

* chore: go back to 1.21 for msrv

* chore: update linter to use 1.21

* chore: go mod tidy

* chore: test against 1.18 as a minimum again

* chore: remove id field

.github/workflows/lint.yml

@@ -20,7 +20,6 @@ jobs:
         uses: actions/setup-go@v3
         with:
           go-version: ^1.21
-          id: go
 
       - name: Check go mod is tidy
         run: |
@@ -33,7 +32,5 @@ jobs:
       - name: Run staticcheck
         run: staticcheck ./...
 
-      - name: Install golangci-lint
-        run: go install github.com/golangci/golangci-lint/cmd/[email protected]
-      - name: Run golangci-lint
-        run: golangci-lint run
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v6

.golangci.yml

@@ -22,7 +22,10 @@ linters:
     #
     # Maybe fix later:
     #
-    - goerr113
+    - mnd
+    - depguard
+    - testifylint
+    - err113
     - stylecheck
     - tagliatelle
 
@@ -32,28 +35,14 @@ linters:
     - contextcheck
     - rowserrcheck
     - sqlclosecheck
-    - structcheck
     - wastedassign
 
-    #
-    # Disabled because deprecated:
-    #
-    - deadcode
-    - exhaustivestruct
-    - golint
-    - ifshort
-    - interfacer
-    - maligned
-    - nosnakecase
-    - scopelint
-    - varcheck
-
 linters-settings:
   gofumpt:
     extra-rules: true
   gosec:
     excludes:
-     - G404 # Insecure random number source (rand)
+      - G404 # Insecure random number source (rand)
   govet:
     enable-all: true
     disable: