From f2b8f3f2f4dab6446a21c2a95d2c38e2386f4080 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 16:45:54 +0100 Subject: [PATCH 01/16] Empty commit for diff From edace382f442b71566abb8aeb51c7567c98a7e26 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 16:48:11 +0100 Subject: [PATCH 02/16] chore: update ci lint version --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 8e3c45f..687ad91 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -34,6 +34,6 @@ jobs: run: staticcheck ./... - name: Install golangci-lint - run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2 + run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2 - name: Run golangci-lint run: golangci-lint run From 09ba1ebf5d48167e93049e33489065520d0254c0 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 16:55:26 +0100 Subject: [PATCH 03/16] chore: switch to golangcilint action --- .github/workflows/lint.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 687ad91..b99de72 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -33,7 +33,5 @@ jobs: - name: Run staticcheck run: staticcheck ./... - - name: Install golangci-lint - run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2 - - name: Run golangci-lint - run: golangci-lint run + - name: golangci-lint + uses: golangci/golangci-lint-action@v3 From 1bf320744eccd52e75f4ff2c986239d0cbd08bf6 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:11:29 +0100 Subject: [PATCH 04/16] chore: update to v6 version of golangcilint --- .github/workflows/lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index b99de72..e50fda0 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -19,7 +19,7 @@ jobs: - name: Set up Go uses: actions/setup-go@v3 with: - go-version: ^1.20 + go-version: ^1.22 id: go - name: Check go mod is tidy @@ -34,4 +34,4 @@ jobs: run: staticcheck ./... - name: golangci-lint - uses: golangci/golangci-lint-action@v3 + uses: golangci/golangci-lint-action@v6 From b5626196b6a89d33741a00cd0a37c1856e4fcf3a Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:31:19 +0100 Subject: [PATCH 05/16] chore: disable mnd --- .golangci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index b8cd0cb..83214c7 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -18,6 +18,7 @@ linters: - varnamelen - wrapcheck - wsl + - mnd # # Maybe fix later: @@ -53,7 +54,7 @@ linters-settings: extra-rules: true gosec: excludes: - - G404 # Insecure random number source (rand) + - G404 # Insecure random number source (rand) govet: enable-all: true disable: From 8d17069d92144f4ce606d6845c9fbae31b118fd8 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:33:24 +0100 Subject: [PATCH 06/16] chore: remove deprecated and deactivated linters --- .golangci.yml | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 83214c7..2a6b48d 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -33,22 +33,8 @@ linters: - contextcheck - rowserrcheck - sqlclosecheck - - structcheck - wastedassign - # - # Disabled because deprecated: - # - - deadcode - - exhaustivestruct - - golint - - ifshort - - interfacer - - maligned - - nosnakecase - - scopelint - - varcheck - linters-settings: gofumpt: extra-rules: true From e3f447b55e8cd1d822b815f3df0cce74c6bc45c5 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:34:33 +0100 Subject: [PATCH 07/16] chore: disable depguard --- .golangci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 2a6b48d..c24d2c9 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -18,11 +18,12 @@ linters: - varnamelen - wrapcheck - wsl - - mnd # # Maybe fix later: # + - mnd + - depguard - goerr113 - stylecheck - tagliatelle From 209a30fcf7de5d285922c98056bca059865918ef Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:37:01 +0100 Subject: [PATCH 08/16] chore: update to go 1.22 --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 4936976..2242249 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/crate-crypto/go-kzg-4844 -go 1.20 +go 1.22 require ( github.com/consensys/gnark-crypto v0.12.1 From 8bd6053cc36f1b47a13324f1bdca8e6e5e41cb87 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:37:09 +0100 Subject: [PATCH 09/16] chore: disable testifylint --- .golangci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.golangci.yml b/.golangci.yml index c24d2c9..849fe2d 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -24,6 +24,7 @@ linters: # - mnd - depguard + - testifylint - goerr113 - stylecheck - tagliatelle From aee65e79e2889b09f6685851dcfaae8c986e023e Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:38:21 +0100 Subject: [PATCH 10/16] chore: goerr13 has been renamed in the linter database --- .golangci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 849fe2d..f65b0c5 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -25,7 +25,7 @@ linters: - mnd - depguard - testifylint - - goerr113 + - err113 - stylecheck - tagliatelle From 03102a4f60aea5dae81df0ecd195d5b628b86d63 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:40:53 +0100 Subject: [PATCH 11/16] chore: update go versions --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 82328af..d146f31 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,9 +18,9 @@ jobs: - macos-latest - windows-latest go-version: - - 1.18.x # Minimmum version - - 1.20.x # Current version - - 1.21.x # Latest version + - 1.20.x # Minimmum version + - 1.21.x # Current version + - 1.22.x # Latest version steps: - uses: actions/checkout@v3 From 892e8bc72e40f75d32a4188f295c74dfa4a4d9a2 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:41:12 +0100 Subject: [PATCH 12/16] chore: go back to 1.21 for msrv --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 2242249..f2a5bbe 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/crate-crypto/go-kzg-4844 -go 1.22 +go 1.21 require ( github.com/consensys/gnark-crypto v0.12.1 From 36f7d9e9edcf49fac34d509ca31980a5d9150b08 Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:43:57 +0100 Subject: [PATCH 13/16] chore: update linter to use 1.21 --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index e50fda0..829e75b 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -19,7 +19,7 @@ jobs: - name: Set up Go uses: actions/setup-go@v3 with: - go-version: ^1.22 + go-version: ^1.21 id: go - name: Check go mod is tidy From f3b6031250bfc2c0c18f9a16775f4c7c58b93edd Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:44:53 +0100 Subject: [PATCH 14/16] chore: go mod tidy --- go.sum | 3 +++ 1 file changed, 3 insertions(+) diff --git a/go.sum b/go.sum index 50ea332..f068471 100644 --- a/go.sum +++ b/go.sum @@ -10,9 +10,11 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/google/subcommands v1.2.0/go.mod h1:ZjhPrFU+Olkh9WazFPsl27BQ4UPiG37m3yTrtFlrHVk= github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE= +github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk= github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY= github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE= github.com/leanovate/gopter v0.2.9 h1:fQjYxZaynp97ozCzfOyOuAGOU4aU/z37zf/tOujFk7c= +github.com/leanovate/gopter v0.2.9/go.mod h1:U2L/78B+KVFIx2VmW6onHJQzXtFb+p5y3y2Sh+Jxxv8= github.com/mmcloughlin/addchain v0.4.0 h1:SobOdjm2xLj1KkXN5/n0xTIWyZA2+s99UCY1iPfkHRY= github.com/mmcloughlin/addchain v0.4.0/go.mod h1:A86O+tHqZLMNO4w6ZZ4FlVQEadcoqkyU72HC5wJ4RlU= github.com/mmcloughlin/profile v0.1.1/go.mod h1:IhHD7q1ooxgwTgjxQYkACGA77oFTDdFVejUS1/tS/qU= @@ -33,6 +35,7 @@ golang.org/x/sys v0.9.0 h1:KS/R3tvhPqvJvwcKfnBHJwwthS11LRhmM5D59eEXa0s= golang.org/x/sys v0.9.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk= +gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q= gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY= gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ= gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= From ddb08b590b09a20fb3173107563de8322c2c315d Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:47:41 +0100 Subject: [PATCH 15/16] chore: test against 1.18 as a minimum again --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d146f31..05d9e21 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,7 +18,7 @@ jobs: - macos-latest - windows-latest go-version: - - 1.20.x # Minimmum version + - 1.18.x # Minimmum version - 1.21.x # Current version - 1.22.x # Latest version From c5589c74e82b059a0ae76a524ef32f04fd3f6f8e Mon Sep 17 00:00:00 2001 From: Kevaundray Wedderburn Date: Thu, 20 Jun 2024 17:50:03 +0100 Subject: [PATCH 16/16] chore: remove id field --- .github/workflows/lint.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 829e75b..43bfb35 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -20,7 +20,6 @@ jobs: uses: actions/setup-go@v3 with: go-version: ^1.21 - id: go - name: Check go mod is tidy run: |