Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Generated code, do not edit" #21

Open
holiman opened this issue May 24, 2022 · 1 comment
Open

"Generated code, do not edit" #21

holiman opened this issue May 24, 2022 · 1 comment

Comments

@holiman
Copy link

holiman commented May 24, 2022

I noticed this when opening a PR touching https://github.com/crate-crypto/go-ipa/blob/master/bandersnatch/fr/element.go , github won't show the diff by default because it's marked as such:

https://github.com/crate-crypto/go-ipa/blob/master/bandersnatch/fr/element.go#L15

// Code generated by consensys/gnark-crypto DO NOT EDIT

It seems that some parts are generated and others are not? If so, it would be better to move all non-generated methods out into a separate file, and keep the pure generated code separate in that file. If the header lies, then it should be removed.

@kevaundray
Copy link
Contributor

Good point. The only additional methods in this file are BytesLE and SetBytesLE, as you said we can put these into another file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants