-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Type: NUMERIC
#652
Comments
It is probably still the right choice to serialize Decimal values as strings, because there is no other way to marshal them through JSON? crate-python/src/crate/client/http.py Lines 95 to 96 in 8a3bf38
In this case, I guess it will be safe to close this issue for the DB API driver, but check crate/sqlalchemy-cratedb#163 instead, if there is something to do for SQLAlchemy, which is more likely? |
If we have the same behavior that we encountered here: crate/crate#16843 |
Thank you. Then, there will be nothing to update or improve, other than the documentation perhaps, also on the Python driver at a relevant spot? As you advise that HTTP/JSON transport may loose precision, may I ask if it would be expectably different when using the PostgreSQL interface? |
Yes, the issue is completely related to HTTP/JSON only. |
and to be more precise, http streams the full number (reaches the client), but the |
About
CrateDB gained a new data type NUMERIC. Most probably, we want to support it here in one way or another.
References
NUMERIC
sqlalchemy-cratedb#163The text was updated successfully, but these errors were encountered: