Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Fall back to php's json_decode internally in simdjson_decode for json length > 4 GiB #89

Open
TysonAndre opened this issue Oct 21, 2022 · 0 comments

Comments

@TysonAndre
Copy link
Collaborator

(instead of throwing SimdJsonException for the capacity error)

simdjson_decode is meant to have indistinguishable behavior from json_decode apart from error codes/classes/messages, so this should be safe

  • Use the JsonException message and a distinct SIMDJSON_ERR* error code

Libraries using simdjson_decode may be forced to add extra error handling if they expect to be used for JSON > 4 GiB by any application using them. It'd be more convenient to avoid that.

Low priority compared to other tasks due to most php installations having max upload sizes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant