Skip to content

Commit 0f3f5a2

Browse files
committed
wip: remove enabling of file sharing a creation of smbshare from MSI
1 parent 457b653 commit 0f3f5a2

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

packaging/windows/product.wxs.template

-24
Original file line numberDiff line numberDiff line change
@@ -92,24 +92,6 @@
9292
Before="AddUserToHypervAdminGroup"
9393
Sequence="execute"/>
9494
<CustomAction Id="AddUserToHypervAdminGroup" BinaryKey="WixCA" DllEntry="WixQuietExec64" Execute="deferred" Impersonate="no" Return="ignore" />
95-
<SetProperty Action="CACreateSMBShare"
96-
Id="CreateSMBShare"
97-
Value="&quot;[POWERSHELLEXE]&quot; -NonInteractive -ExecutionPolicy Bypass -NoProfile -Command &quot;New-SmbShare -Name '[SHAREDDIRNAME]' -Path '[USERFOLDER]' -FullAccess '[LogonUser]'&quot;"
98-
Before="CreateSMBShare"
99-
Sequence="execute"/>
100-
<CustomAction Id="CreateSMBShare" BinaryKey="WixCA" DllEntry="WixQuietExec64" Execute="deferred" Impersonate="no" Return="ignore" />
101-
<SetProperty Action="CAEnableFileAndPrinterSharing"
102-
Id="EnableFileAndPrinterSharing"
103-
Value="&quot;[POWERSHELLEXE]&quot; -NonInteractive -ExecutionPolicy Bypass -NoProfile -Command &quot;Set-NetFirewallRule -Group '@FirewallAPI.dll,-28502' -Enabled True -Profile 'Private,Public'&quot;"
104-
Before="EnableFileAndPrinterSharing"
105-
Sequence="execute"/>
106-
<CustomAction Id="EnableFileAndPrinterSharing" BinaryKey="WixCA" DllEntry="WixQuietExec64" Execute="deferred" Impersonate="no" Return="ignore" />
107-
<SetProperty Action="CARemoveSMBShare"
108-
Id="RemoveSMBShare"
109-
Value="&quot;[POWERSHELLEXE]&quot; -NonInteractive -ExecutionPolicy Bypass -NoProfile -Command &quot;Remove-SmbShare -Name '[SHAREDDIRNAME]' -Force&quot;"
110-
Before="RemoveSMBShare"
111-
Sequence="execute"/>
112-
<CustomAction Id="RemoveSMBShare" BinaryKey="WixCA" DllEntry="WixQuietExec64" Execute="deferred" Impersonate="no" Return="ignore" />
11395

11496
<InstallExecuteSequence>
11597
<Custom Action="CreateCrcGroup" Before="ConfigureUsers"> NOT Installed AND NOT REMOVE~="ALL" AND NOT WIX_UPGRADE_DETECTED</Custom>
@@ -118,9 +100,6 @@
118100
<Custom Action="InstallHyperv" Before="CreateCrcGroup"> NOT Installed AND NOT REMOVE~="ALL" AND NOT WIX_UPGRADE_DETECTED</Custom>
119101
<Custom Action="RemoveCrcGroupRollback" After="CreateCrcGroup"> NOT Installed AND NOT REMOVE~="ALL" AND NOT WIX_UPGRADE_DETECTED</Custom>
120102
<Custom Action="RemoveCrcDaemonTask" Before='RemoveFiles'>Installed AND NOT UPGRADINGPRODUCTCODE</Custom>
121-
<Custom Action="EnableFileAndPrinterSharing" After="AddUserToHypervAdminGroup"> NOT Installed AND NOT REMOVE~="ALL" AND NOT WIX_UPGRADE_DETECTED</Custom>
122-
<Custom Action="CreateSMBShare" After="EnableFileAndPrinterSharing"> NOT Installed AND NOT REMOVE~="ALL"</Custom>
123-
<Custom Action="RemoveSMBShare" After='RemoveCrcDaemonTask'>Installed AND NOT UPGRADINGPRODUCTCODE</Custom>
124103
<ScheduleReboot After="InstallFinalize"> NOT Installed AND NOT REMOVE~="ALL" AND NOT WIX_UPGRADE_DETECTED</ScheduleReboot>
125104
</InstallExecuteSequence>
126105
<Feature Id="DefaultFeature" Title="Install core features" Absent="disallow" Level="1">
@@ -140,9 +119,6 @@
140119
<ProgressText Action="InstallHyperv">Installing Hyper-V</ProgressText>
141120
<ProgressText Action="AddUserToHypervAdminGroup">Adding user: [LogonUser] to Hyper-V Administrators group</ProgressText>
142121
<ProgressText Action="RemoveCrcDaemonTask">Removing crcDaemon task</ProgressText>
143-
<ProgressText Action="CreateSMBShare">Creating share named: [SHAREDDIRNAME] for folder: [USERFOLDER]</ProgressText>
144-
<ProgressText Action="RemoveSMBShare">Removing share named: [SHAREDDIRNAME] for folder: [USERFOLDER]</ProgressText>
145-
<ProgressText Action="EnableFileAndPrinterSharing">Enabling file and printer Sharing</ProgressText>
146122
</UI>
147123
<Property Id="WIXUI_INSTALLDIR" Value="INSTALLDIR" />
148124
<!-- this should help to propagate env var changes -->

0 commit comments

Comments
 (0)