API Deprecate passing null paramters for Form and ValidationResult me…

…thods
creative-commoners · Jan 17, 2025 · 64eca78 · 64eca78
1 parent 7088fb3
commit 64eca78
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/en/08_Changelogs/5.4.0.md b/en/08_Changelogs/5.4.0.md
@@ -320,6 +320,14 @@ See [indexes](/developer_guides/model/indexes/) to learn about indexes in Silver
 - The `$join` parameter for the [`Subsite::get_from_all_subsites()`](api:SilverStripe\Subsites\Model\Subsite::get_from_all_subsites()) method has been deprecated. Use [leftJoin($table, $joinClause)](api:SilverStripe\ORM\DataList::leftJoin()) instead.
 - Passing a boolean value to the `$mergeStrategy` argument in [`Form::loadDataFrom()`](api:Silverstripe\Forms\Form::loadDataFrom()) has been deprecated. Pass [`Form::MERGE_CLEAR_MISSING`](api:Silverstripe\Forms\Form::MERGE_CLEAR_MISSING) instead of `true` and `0` instead of `false`.
 - The [`HTTP.ignoreDeprecatedCaching`](api:SilverStripe\Control\HTTP->ignoreDeprecatedCaching) configuration property has been deprecated. It will be removed without equivalent functionality to replace it.
+- Passing `null` for the `$code` parameter in [`ValidationResult::addError()`](api:SilverStripe\ORM\ValidationResult::addError()) is deprecated. Pass a blank string instead.
+- Passing `null` for the `$cast` parameter in [`ValidationResult::addError()`](api:SilverStripe\ORM\ValidationResult::addError()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
+- Passing `null` for the `$code` parameter in [`ValidationResult::addFieldError()`](api:SilverStripe\ORM\ValidationResult::addFieldError()) is deprecated. Pass a blank string instead.
+- Passing `null` for the `$cast` parameter in [`ValidationResult::addFieldError()`](api:SilverStripe\ORM\ValidationResult::addFieldError()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
+- Passing `null` for the `$code` parameter in [`ValidationResult::addMessage()`](api:SilverStripe\ORM\ValidationResult::addMessage()) is deprecated. Pass a blank string instead.
+- Passing `null` for the `$cast` parameter in [`ValidationResult::addMessage()`](api:SilverStripe\ORM\ValidationResult::addMessage()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
+- Passing `null` for the `$code` parameter in [`ValidationResult::addFieldMessage()`](api:SilverStripe\ORM\ValidationResult::addFieldMessage()) is deprecated. Pass a blank string instead.
+- Passing `null` for the `$cast` parameter in [`ValidationResult::addFieldMessage()`](api:SilverStripe\ORM\ValidationResult::addFieldMessage()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
 
 ## Bug fixes