Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Standardize LegalDB Logo Format According to Vocabulary Guidelines #254

Open
1 task done
rypptc opened this issue Oct 25, 2024 · 1 comment
Open
1 task done
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@rypptc
Copy link
Contributor

rypptc commented Oct 25, 2024

Problem

The logo on the legaldb page is not in line with the examples described in Vocabulary, (index-logo.html and product-logo.html). This causes the appearance of the page to differ from the criteria established in the Vocabulary design system.

Description

Modify the code related to the logo in the header of the legaldb project so that it complies with the design established in Vocabulary.

This issue may be replicated in open source site if accepted, since it has a similar implementation of its logo.

Alternatives

Additional context

legaldb relevant code

<header class="container">
  <nav class="navbar">
    <div class="navbar-brand">
      <a class="has-text-black" href="/">
        <img src="/static/logo.d6336c44eac1.svg" alt="CC legal database logo">
      </a>
...
    </div>
...
  </nav>
</header>

Vocabulary index-logo.html example relevant code

<header>
    <div class="masthead">
        <h1><a class="identity-logo" href="#">Creative Commons</a></h1>
...

    </div>

...

</header>

How it currently looks

image

How does Vocabulary example looks

image

Even the difference is not that evident, the fact of having some sites using an svg image instead of text and using different html tags and classes as those indicated in Vocabulary is inconsistent with the design system.

Implementation

  • I would be interested in implementing this feature.
@rypptc rypptc added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 25, 2024
@cc-open-source-bot cc-open-source-bot moved this to Triage in Applications Oct 25, 2024
@TimidRobot TimidRobot self-assigned this Oct 30, 2024
@TimidRobot TimidRobot added 🚧 status: blocked Blocked & therefore, not ready for work 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 💻 aspect: code Concerns the software code in the repository labels Oct 30, 2024
@TimidRobot TimidRobot moved this to Backlog in WebDev Oct 30, 2024
@TimidRobot
Copy link
Member

@TimidRobot TimidRobot removed their assignment Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work
Projects
Status: Backlog
Development

No branches or pull requests

2 participants