Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Padding missing on the most of the pages on smaller devices #276

Open
1 task done
OmarAmeen01 opened this issue Oct 21, 2024 · 11 comments
Open
1 task done

[Bug] Padding missing on the most of the pages on smaller devices #276

OmarAmeen01 opened this issue Oct 21, 2024 · 11 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work

Comments

@OmarAmeen01
Copy link
Contributor

Description

Most of the pages in the design system don't have padding on content on smaller devices viz the title or the description of the page and other elements
which makes content stick to the wall and jumbles the overall view of the page

Reproduction

  1. Go live on any page eg default-page, person-page, home-index.
  2. switch to responsive mode.
  3. see the content sticking to the wall.

Expectation

the content should have padding on the left and right which improves its readability

Screenshots

default-page

default page padding less

home-index

home page padding lesss

person-page

person-page html

Environment

  • Device: (iPhone Xs; laptop:Andriod )
  • OS: ( iOS 13.5; Fedora 32: Windows )
  • Browser: ( Safari; Firefox: Chrome)

Resolution

  • I would be interested in resolving this bug.
@OmarAmeen01 OmarAmeen01 added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Oct 21, 2024
@possumbilities
Copy link
Contributor

This is a duplicate of several other Issues. However, I think this is the only one thus far that approaches this from a more overall approach, rather than one or two specific contexts. I'm leaving it here for now.

@OmarAmeen01 Would you please link all the padding related Issues in a comment here?

@possumbilities possumbilities added 🧹 status: ticket work required Needs more details before it can be worked on and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 22, 2024
@possumbilities possumbilities moved this from Triage to Backlog in possumbilities Oct 22, 2024
@possumbilities possumbilities added 🟨 priority: medium Not blocking but should be fixed soon and removed 🟧 priority: high Stalls work on the project or its dependents labels Oct 22, 2024
@OmarAmeen01
Copy link
Contributor Author

yes @possumbilities I would be glad to add all padding related issues here

@OmarAmeen01
Copy link
Contributor Author

@possumbilities can I change this Issue description that covers wide range of issues related to the responsiveness of this design system I would have covered them in this issue but I thought this would lead to big PR.

@OmarAmeen01
Copy link
Contributor Author

@possumbilities Linked all the issues related to the padding here that I could find If anyone has issue related to padding that is not listed here please link it here

@Immy-delish
Copy link
Contributor

Thank you @OmarAmeen01 for linking all the related issues. Maybe the name of the issue can then be changed and we see how we can resolve this.

@lauracastrotech
Copy link

@OmarAmeen01 I am looking at all the issues related to this with @Immy-delish and when we go to the blog and put the responsive mode on, there is no issue with padding and the page responds well when we shrink the sized. Does this mean that the issue is resolved and maybe @possumbilities hasn't been able to make the change? we don't want to duplicate work

@OmarAmeen01
Copy link
Contributor Author

@lauracastrotech there is a padding related issue there . only thing is that it doesn't have less padding it has more padding which squeezes the content everything around it

@kris70lesgo
Copy link

Hi @possumbilities , I believe I can tackle this issue. I have experience working on mobile responsiveness and CSS padding issues. I’d be happy to address the padding issues across all affected pages and ensure mobile-friendly padding for better readability. Could you please assign this issue to me

@possumbilities
Copy link
Contributor

@kris70lesgo Hi! We don't assign Issues until PRs are merged

Please see the Contribution Guidelines

Additionally, this ticket needs more thorough documentation since I believe this affects more than the listed contexts above; before it can move away from 🧹 status: ticket work required Needs more details before it can be worked on It would be helpful if you want to try to tackle that first here within a comment.

@possumbilities
Copy link
Contributor

possumbilities commented Jan 21, 2025

Adding some further context here: The main content area across a variety of contexts lacks adequate padding. A change here should be discrete an try to correct as many contexts as possible in the cascade rather than try overly specific fixes.

likely covered in part by other Issues, we'll track work here to try to keep it applicable across contexts:

@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🧹 status: ticket work required Needs more details before it can be worked on labels Jan 21, 2025
@possumbilities possumbilities self-assigned this Jan 21, 2025
@possumbilities
Copy link
Contributor

I'm assigning this to myself, but if anyone wants to take a shot at correcting this, feel free to submit a PR.

@possumbilities possumbilities changed the title [Bug] Padding missing on the most of the pages on smalller devices [Bug] Padding missing on the most of the pages on smaller devices Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Development

No branches or pull requests

5 participants