Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel component ignores data-interval="false" #31

Open
3 tasks done
cregx opened this issue Sep 10, 2018 · 1 comment
Open
3 tasks done

Carousel component ignores data-interval="false" #31

cregx opened this issue Sep 10, 2018 · 1 comment

Comments

@cregx
Copy link

cregx commented Sep 10, 2018

Prerequisites

  • I am running the latest version 1.2.2 (Now UI Kit Pro)
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Expected Behavior

When setting data-interval to "false" I expect that no automatic start of the carousel is performed.

Current Behavior

The carousel component always runs - even if I use false.

Failure Information

Steps to Reproduce

  1. Use these values: <div class="carousel slide" data-ride="carousel" data-type="multi" data-interval="false" id="productCarousel">
  2. Test the behavior: the carousel starts automatically.
  3. Replace the bootstrap.min.js with the latest master and check the behavior again: the carousel does not start automatically.
  4. Change the data-interval setting from "false" to e.g. "8000" and vice versa to evaluate the test.
@dragosct
Copy link
Member

Hi, @cregx! Thank you for using our products. This is happening because in your project folder in assets/js/now-ui-kit.js file you have in ready function the following lines of code:

$('.carousel').carousel({
        interval: 4000
    });

To fix the problem please remove the interval option.

Regards,
Dragos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants