-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure app can still be built on xcode 14, since xcode 15 is in beta #564
Conversation
2b32033
to
9aecf5c
Compare
Hi @creepymonster! First time contributor here. I'd love to get this merged in to make the app locally-buildable again (and probably fix the CI error currently in What needs to be done to get this code reviewed, merged, and hopefully tagged as a new TestFlight build? |
It works. Thx. |
@creepymonster Mind taking a look at this (and the other) pull requests I posted recently? thanks! |
@creepymonster may we please get this merged in? |
9aecf5c
to
5a1cbee
Compare
Looks like no merging of PR or maintenance is going on :( I wanted to get some improvements in too, but it looks like that won't help |
Yeah, I'm not sure why. I saw new commits come in and new releases on TestFlight, but it seems like the developer community (which is trying to help) is sadly being ignored. :( |
Do you have an Apple developer account ? I don't and need to borrow my son's Macbook to access xcode, but I was wondering if it would be possible to keep improving on your fork and push it to TestFlight, in a hope that those PR would eventually get merged here too ? |
@gui-dos I cannot believe that ! I'm in BE, and we are moving to Libre3 too. In fact, I just applied my last Libre2 patch TODAY, in 14 days I'll be on Libre3 :D. Heading to your repo |
@DAcodedBEAT can you publish on testflight app coming from your fork ? |
I will try, this is my first attempt at iOS development and I want to do things in a reproducible manner (releases triggered by CI, build versions generated in CI, etc). This being said, I don't know how much time I will be able to invest in this but for now, I'll try to get this published. (In the future, I might try to reimplement this in a cross-platform manner with react-native/expo so it works on iOS and android) |
It looks like I can't create an AppStoreConnect entry for a project with the same name. :( |
Will do as soon as I manage to get my hand on Apple silicon machine ;) |
Closing as xcode 15 is the default now (also removed from my fork once it became the default - https://github.com/DAcodedBEAT/GlucoseDirect) |
Currently the following error is reported when building with the latest stable Xcode:
Error: Value of type 'EKEventStore' has no member 'requestFullAccessToEvents'
.requestFullAccessToEvents
is a new method only available in iOS 17, which is in beta, and is also only supported by Xcode 15, which is also in beta.Since this feature is dependent on beta APIs which aren't available on older Xcodes, this application will not build. As a result, this conditional needs additional safeguards in order to compile properly on the latest stable Xcode.
note: Since there isn't a way to check which version of Xcode is used, I needed to check based on the available Swift version, which is published on Apple's documentation: https://developer.apple.com/support/xcode/
Resolves #563