Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New feature] Manage command configuration #119

Open
bhou opened this issue Apr 3, 2023 · 2 comments
Open

[New feature] Manage command configuration #119

bhou opened this issue Apr 3, 2023 · 2 comments

Comments

@bhou
Copy link
Collaborator

bhou commented Apr 3, 2023

Add a new type of command launcher managed resource: "config". Each command can request to such configurations in requestedResources property.

A package should also declare the list of configurations it requires so that the command launcher can provide a proper interface to access them.

Example manifest:

pkgName: demo-pkg
version: 1.0.0
cmds:
  - name: test-cmd
     type: executable
     requiredResources: [ 'CONFIG_NAME_1', 'CONFIG_NAME_2' ]

configs:
  - name: NAME_1
    type: string
    default: hello
  - name: NAME_2
     type: integer
     default: 10
@dufrannea
Copy link

Maybe a small extension to this issue:
I have a command that requires two environment variables to be run, MYCOMMAND_USER and MYCOMMAND_APIKEY (MYCOMMAND_APIKEY is a secret value).
I wonder if it would make sense for command launcher to be able to store such values securely, what do you think ?

@jdevera
Copy link
Contributor

jdevera commented Jun 28, 2024

Would this mean the values can be set up using the config command and that the storage would be managed by the launcher?
If so, and if the interface is env vars, then I think there would be some checks for clashes or some implicit namespacing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants