Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor VRF model by removing device foreign key #28

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: refactor VRF model by removing device foreign key #28

merged 1 commit into from
Dec 18, 2023

Conversation

djothi
Copy link
Contributor

@djothi djothi commented Dec 18, 2023

Fix: remove device fk in VRF model

Description:
This PR refactors the VRF model by removing the device foreign key. VRFs are attached to a device through others entities such as LogicalInterface, BGP model(s), etc

After the commit:

Removes the device foreign key from the VRF model.

@djothi djothi requested review from a team December 18, 2023 12:40
kpetremann
kpetremann approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@kpetremann kpetremann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't link directly the devices, it might require to update the DRF endpoint to expose the VRF per devices (to construct the list and create/remove VRFs)

@djothi djothi merged commit a606411 into criteo:main Dec 18, 2023
2 checks passed
@djothi djothi deleted the remove_vrf_device_fk branch December 18, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpetremann kpetremann kpetremann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djothi @kpetremann