feat(deprecated): generate language specific deprecation markup #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deprecated text in comments If @deprecated is present in a comment, a deprecation marker will be generated. @deprecated is expected to be at the start of a line, any text following it on the same line is added as the ‘message’ text where supported This applies to records/attributes/constants, interfaces/methods/constants, enums/values, flags/values Supports C++, Java and ObjC generators
eakoli
force-pushed
the
feat-deprecated-support
branch
from
f8b6960 to
64cf608
Compare
|
Wow, this is nice! Thank you so much!! |
a4z
approved these changes
Nov 2, 2023
|
Could be nice if this would also support setting the |
jothepro
approved these changes
Nov 3, 2023
|
If no other comments are made, I will soon merge this PR, and we will handle eventual ideas and additions, like docs, as extra issues. |
|
Thanks a lot! |
trblunt
pushed a commit
to trblunt/djinni
that referenced
this pull request
Oct 3, 2024
Adds support for special handling of the @deprecated annotation in IDL comments. When encountered, the generator will output language specific deprecation markup. This change is a port of the existing deprecation support in the cross-language-cpp repository. Ported "feat(deprecated): generate language specific deprecation markup" Original author: @eakoli Original PR: cross-language-cpp/djinni-generator#156
trblunt
added a commit
to trblunt/djinni
that referenced
this pull request
Oct 3, 2024
Adds support for special handling of the @deprecated annotation in IDL comments. When encountered, the generator will output language specific deprecation markup. This change is a port of the existing deprecation support in the cross-language-cpp repository. Ported "feat(deprecated): generate language specific deprecation markup" Original author: @eakoli Original PR: cross-language-cpp/djinni-generator#156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If @deprecated is present in a comment, a deprecation marker will be generated.
@deprecated is expected to be at the start of a line, any text following it on the same line is added as the ‘message’ text where supported
This applies to records/attributes/constants, interfaces/methods/constants, enums/values, flags/values
Supports C++, Java and ObjC generators