Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance toolchain update 2023 #159

Merged
merged 8 commits into from
Nov 18, 2023

Conversation

a4z
Copy link
Contributor

@a4z a4z commented Nov 11, 2023

Since we are going to have a release soon,
It would be a good idea to update scala and sbt also
and also check the current dependencies if they need any update

@@ -1,11 +1,16 @@
import sbtassembly.AssemblyPlugin.defaultUniversalScript

ThisBuild / scalaVersion := "2.13.6"
ThisBuild / scalaVersion := "2.12.18"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional, 2.13 brings 100 + deprecations,
so first, get a clean 2.12 state, and then move on

@a4z
Copy link
Contributor Author

a4z commented Nov 11, 2023

This is quite a huge update, but it makes scala 2.12.18 (latest 2.12) work with all deprecation warnings and other warnings fixed.
(2 unused variable warnings are left, but I think this is an error in the tool)

2.13 will bring a huge bulk of new deprecation warnings, so I keep this for a later update, since 2.12 is still maintained.

@a4z a4z requested review from freitass and jothepro November 11, 2023 22:21
@a4z a4z marked this pull request as ready for review November 11, 2023 22:21
@mutagene
Copy link
Contributor

Don't suppose you can wait until I finish with the web assembly support🤞

@a4z
Copy link
Contributor Author

a4z commented Nov 12, 2023

It depends on the timing. I would like to have this out and make a release with the new functionality.
Also, pin the Scala version and add the tools. This will help with newly written code.

This might cause merge issues. No worries, I can help resolve them.
I will not leave you alone in case of problems. The plan is helping you to merge main into your branch, and have all the new checks applied to the new code.

Btw, this PR shows quite well the maintenance cost of code that is not in use, like the Python generator. And why I ask for additions of code that has more to show than some unit test, like a small demo app

@mutagene
Copy link
Contributor

It's fine. Worried about conflicts, but really any conflicts from this PR are nothing next to what has to be done with the support lib 😅

@a4z
Copy link
Contributor Author

a4z commented Nov 17, 2023

Don't plan to add any more changes for now.

Hope I will get at least some review, to not be forced to bypass our review policies

Copy link
Contributor

@freitass freitass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, and thanks for keeping this project alive :)

@a4z a4z merged commit a965d71 into cross-language-cpp:main Nov 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants