Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemberRoleId not set when creating SamlGroupLink #157

Open
jeremyj563 opened this issue Aug 29, 2024 · 0 comments
Open

MemberRoleId not set when creating SamlGroupLink #157

jeremyj563 opened this issue Aug 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jeremyj563
Copy link

What happened?

When creating a managed resource of type SamlGroupLink the property MemberRoleId is not set. This field is necessary for creating a SAML Group Link to a Custom Member Role in GitLab.

How can we reproduce it?

We can see this property is missing in GenerateAddSamlGroupLinkOptions() here:

// GenerateAddSamlGroupLinkOptions is used to produce Options for SamlGroupSync creation
func GenerateAddSamlGroupLinkOptions(p *v1alpha1.SamlGroupLinkParameters) *gitlab.AddGroupSAMLLinkOptions {
samlGroupName := &gitlab.AddGroupSAMLLinkOptions{
SAMLGroupName: p.Name,
AccessLevel: (*gitlab.AccessLevelValue)(&p.AccessLevel),
}
return samlGroupName
}

(also kindly note the minor typo in the comment on line 53)

What environment did it happen in?

Crossplane version: 1.16.0
Crossplane Provider GitLab version: 0.9.0

@jeremyj563 jeremyj563 added the bug Something isn't working label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant