Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support including import credentials for Project via secretRef #48

Open
nrhtr opened this issue Aug 19, 2021 · 3 comments · May be fixed by #138
Open

Support including import credentials for Project via secretRef #48

nrhtr opened this issue Aug 19, 2021 · 3 comments · May be fixed by #138
Labels
enhancement New feature or request

Comments

@nrhtr
Copy link

nrhtr commented Aug 19, 2021

What problem are you facing?

I would like to be able to supply credentials using a Secret for the provider when importing a project from an external URL.

How could Crossplane help solve your problem?

Currently the only way to do this appears to be to include the username/token directly in the importUrl parameter. I would like to be able to reference a secret instead.

If this sounds reasonable I'm happy to work on contributing this. Thanks.
@nrhtr nrhtr added the enhancement New feature or request label Aug 19, 2021
@janwillies
Copy link
Collaborator

Hey nrhtr! Thanks for rising this.

Something like importUrlSecretRef sounds like a great addition 👍happy to review!

@cristian98149
Copy link

cristian98149 commented May 11, 2023 •
edited
Loading

Hi, has this field been implemented?

@MisterMX
Copy link
Collaborator

@cristian98149 no work has been done so far. Feel free to open a PR for this and assign me as a reviewer.

@frkouokam frkouokam linked a pull request Apr 29, 2024 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat:Including import credentials for project via secretRef frkouokam/provider-gitlab
4 participants
@nrhtr @janwillies @MisterMX @cristian98149