-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add http client and tlsSecretRef #25
base: main
Are you sure you want to change the base?
Conversation
still need to redo all tests |
@Avarei : Thanks for this PR, I am waiting for this too. I need it to have possibilities to talk to internal API using Certificate authentication. |
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
thanks @barunavo for bringing this back to my attention. I neeeded to update golangci-lint since the previous version seemed to leak memory on every system I tried to run it. I also tried this functionality in a cluster using disposablerequests and I could not find any issues so far. I have not yet used the non-disposable requests and I hope that someone can take a look at them. |
Signed-off-by: Tim <[email protected]>
Thanks for the PR @Avarei , may be I will try to take care of the non-disposable request, not sure when I find time. |
Description of your changes
Add http.Client to httpClient.
add mTLS support to CRDs using new tlsSecretRef field which expects a secret containing tls.crt, tls.key, and/or ca.crt
Fixes #21
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested