Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeploymentRuntimeConfig #50

Closed
wmendes-ionos opened this issue Aug 16, 2024 · 2 comments
Closed

DeploymentRuntimeConfig #50

wmendes-ionos opened this issue Aug 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@wmendes-ionos
Copy link

wmendes-ionos commented Aug 16, 2024

What problem are you facing?

The majority of providers can use a DeploymentRuntimeConfig in order to configure specifics to the package-runtime container.
I couldn't find a way to configure one for the provider-http. How can I change the package-runtime container? e.g(Add env vars, mount volumes etc.)

How could Crossplane help solve your problem?

Allow DeploymentRuntimeConfig for provider-http.

@wmendes-ionos wmendes-ionos added the enhancement New feature or request label Aug 16, 2024
@arielsepton
Copy link
Member

Hi, @wmendes-ionos the provider-http supports configuring the package-runtime container using DeploymentRuntimeConfig. Have you tried the following?

apiVersion: pkg.crossplane.io/v1
kind: Provider
metadata:
  name: provider-http
spec:
  package: <the desired provider-http package>
  runtimeConfigRef:
    apiVersion: pkg.crossplane.io/v1beta1
    kind: DeploymentRuntimeConfig
    name: provider-http-runtime-config
---
apiVersion: pkg.crossplane.io/v1beta1
kind: DeploymentRuntimeConfig
metadata:
  name: provider-http-runtime-config
spec:
  deploymentTemplate:
    spec:
      template:
        spec:
          containers:
          - args:
            - --debug

This configuration should enable debug logs, for instance.

@wmendes-ionos
Copy link
Author

Thank you @arielsepton this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants