Request spec doesn't get updated with new action feature

[miguellobato84]

Hello!

I've testing latest action feature and works great. I didn't manage to get the exact reason, but when deleting the resource it raises the following error:
Mapping not found for action OBSERVE, trying to find mapping by method GET {"request": "create-key"}

Taking a look at the spec, actions are not there. Example:

spec:
  deletionPolicy: Delete
  forProvider:
    headers:
      Authorization:
        - ("Bearer xxxxx")
      Content-Type:
        - application/json
    insecureSkipTLSVerify: true
    mappings:
      - body: |
          {
            "team_id": .payload.body.team_id, 
            "team_alias": .payload.body.team_alias, 
            "max_budget": .payload.body.max_budget,
            "tpm_limit": .payload.body.tpm_limit,
            "rpm_limit": .payload.body.rpm_limit,
            "blocked": .payload.body.blocked
          }
        method: POST
        url: (.payload.baseUrl + "/team/new")
      - method: GET
        url: >-
          (.payload.baseUrl + "/team/info?team_id=" +
          (.payload.body.team_id|tostring))
      - body: |
          {
            "team_id": .payload.body.team_id, 
            "team_alias": .payload.body.team_alias, 
            "max_budget": .payload.body.max_budget,
            "tpm_limit": .payload.body.tpm_limit,
            "rpm_limit": .payload.body.rpm_limit,
            "blocked": .payload.body.blocked
          }
        method: POST
        url: (.payload.baseUrl + "/team/update")
      - body: |
          {
            "team_ids": [.payload.body.team_id]
          }
        method: POST
        url: (.payload.baseUrl + "/team/delete")
    payload:
      baseUrl: xxxxxx
      body: |
        {
            "team_id": "test",
            "team_alias": "test",
            "max_budget": 100,
            "tpm_limit": 50,
            "rpm_limit": 50,
            "blocked": false
        }
    waitTimeout: 5m0s

for reference, this is the request manifest

apiVersion: http.crossplane.io/v1alpha2
kind: Request
metadata:
  name: create-key
spec:
  forProvider:
    insecureSkipTLSVerify: true
    waitTimeout: 5m
    headers:
      Content-Type:
        - application/json
      Authorization:
        - ("Bearer xxxx")
    payload:
      baseUrl: xxxx
      body: |
        {
            "key_alias": "test",
            "team_id": "test"
        }
    mappings:
      - action: CREATE
        method: "POST"
        url: (.payload.baseUrl + "/key/generate")
        body: |
          {
            "key_alias": .payload.body.key_alias,
            "team_id": .payload.body.team_id
          }
      - action: OBSERVE
        method: "GET"
        url: (.payload.baseUrl + "/key/info?key=" + (.response.body.key|tostring))
      - action: UPDATE
        method: "POST"
        url: (.payload.baseUrl + "/key/update")
        body: |
          {
            "key": .response.body.key, 
            "key_alias": .payload.body.key_alias, 
            "team_id": .payload.body.team_id
          }
      - action: REMOVE
        method: "POST"
        url: (.payload.baseUrl + "/key/delete")
        body: |
          {
            "keys": [.response.body.key]
          }
    expectedResponseCheck:
      type: CUSTOM
      logic: |
        if .response.body.info.key_alias == .payload.body.key_alias
         and .response.body.info.team_id == .payload.body.team_id
         then true
         else false
         end

  providerConfigRef:
    name: http-conf

Thanks!

[arielsepton]

Hi! @miguellobato84

Thanks for testing the latest action feature! Regarding the log you’re seeing:

That message is actually a DEBUG log, not an error. It’s triggered by this line in the code.

It simply indicates that no mapping was found for the given action, so the system defaults to searching by HTTP method. If everything is working as expected, you can safely ignore the log.

Let me know if you encounter any issues with the actions themselves!

Thanks!

[arielsepton]

Also, it seems that the latest Request CRD may not be installed, which could be why the actions aren’t being recognized in the deployed request. I recommend running make generate and then applying the updated CRD to ensure everything is up-to-date.

[miguellobato84]

mmm not sure, I just removed everything and installed again and it got stuck in the REMOVE loop

as you can see in the manifest, I declared all actions

[arielsepton]

As I mentioned, this is a DEBUG log, not an error. Could you share the Request CustomResourceDefinition (CRD)? My thought is that it might not be up-to-date, which could explain why the action field is not being recognized.

[miguellobato84]

Hi, request it's in the first message, thanks

[arielsepton]

I actually meant the Request CustomResourceDefinition (CRD) itself, not the request resource.
But I just released a new version of the provider, so you can try it out and see if it works.