Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.47] Bump upjet to 1.1.3 #1195

Merged

Conversation

sergenyalcin
Copy link
Collaborator

Description of your changes

This PR bumps the upjet dependency to 1.1.2 for including StateFunc fix.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@sergenyalcin sergenyalcin changed the title Bump upjet to 1.1.2 [release-0.47] Bump upjet to 1.1.2 Mar 6, 2024
@sergenyalcin
Copy link
Collaborator Author

/test-examples="examples/ec2/vpc.yaml"

@sergenyalcin sergenyalcin changed the title [release-0.47] Bump upjet to 1.1.2 [release-0.47] Bump upjet to 1.1.3 Mar 6, 2024
@sergenyalcin
Copy link
Collaborator Author

/test-examples="examples/ec2/vpc.yaml"

@sergenyalcin sergenyalcin force-pushed the bump-upjet branch 2 times, most recently from f4b0fc0 to 4a664f7 Compare March 6, 2024 23:02
@sergenyalcin
Copy link
Collaborator Author

/test-examples="examples/ec2/vpc.yaml"

@sergenyalcin
Copy link
Collaborator Author

sergenyalcin commented Mar 7, 2024

Because of the shared runner disk issues, for now, we ran the following jobs locally:

check-diff (locally passed) ✅
unit-tests (locally passed) ✅

Also, the uptest runs cover the local-deploy job. In other words, in uptest runs, we ensure that the packages are correctly deployed because the work done in local-deploy is done.

@ulucinar
Copy link
Collaborator

ulucinar commented Mar 7, 2024

Regarding the failing jobs, let me open a PR which conditionally introduces the disk cleanup step and see if it helps here. I remember these were failing previously for this branch.

Signed-off-by: Sergen Yalçın <[email protected]>
- apigateway.IntegrationResponse
- rds.v1beta1.Instance

Signed-off-by: Sergen Yalçın <[email protected]>
- docdb.ClusterInstance
- elasticache.Cluster
- elasticache.ReplicationGroup

Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergenyalcin. Please see #1188 for the review.

Signed-off-by: Sergen Yalçın <[email protected]>
@sergenyalcin sergenyalcin merged commit cae7aab into crossplane-contrib:release-0.47 Mar 7, 2024
9 checks passed
@sergenyalcin sergenyalcin deleted the bump-upjet branch March 7, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants