Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./hack/prepare.sh script not working #264

Closed
ranour93 opened this issue Aug 23, 2023 · 4 comments
Closed

./hack/prepare.sh script not working #264

ranour93 opened this issue Aug 23, 2023 · 4 comments
Labels
bug Something isn't working needs:information

Comments

@ranour93
Copy link

I followed the steps in this documentation: https://github.com/upbound/upjet/blob/main/docs/generating-a-provider.md
to create my own crossplane provider from a terraform provider. I ran into this error with the ./hack/prepare.sh script:

  • read -r -p 'Lower case provider name (ex. github): ' PROVIDER_NAME_LOWER
    Lower case provider name (ex. github): xxxxx
  • read -r -p 'Normal case provider name (ex. GitHub): ' PROVIDER_NAME_NORMAL
    Normal case provider name (ex. GitHub): xxxxx
  • read -r -p 'Organization (ex. xxxxx, my-org-name): ' ORGANIZATION_NAME
    Organization (ex. xxxxxx, my-org-name): xxxxxx
  • read -r -p 'CRD rootGroup (ex. xxxxxxx.io, crossplane.io): ' CRD_ROOT_GROUP
    CRD rootGroup (ex. xxxxxxxx.io, crossplane.io): xxxxxxxxxx.io
  • REPLACE_FILES='./* ./.github :!build/** :!go.* :!hack/prepare.sh'
  • git grep -l template -- ./apis ./build ./cluster ./cmd ./CODE_OF_CONDUCT.md ./CODEOWNERS ./config ./examples ./go.mod ./go.sum ./hack ./internal ./LICENSE ./Makefile ./Makefile.bak ./OWNERS.md ./package ./README.md ./README.md.bak ./scripts ./.github ':!build/**' ':!go.*' ':!hack/prepare.sh'
  • xargs sed -i.bak s/upjet-provider-template/provider-xxxxxx/g
    sed: no input files

Any suggestions on how I can proceed?

@ranour93 ranour93 added bug Something isn't working needs:triage labels Aug 23, 2023
@turkenf
Copy link
Collaborator

turkenf commented Aug 27, 2023

Hi @ranour93, thank you for raising this issue,

Can you give us more information so that we can fully understand the issue, and which provider are you working on?

@haarchri
Copy link
Contributor

@ranour93 which OS you using ?

@ranour93
Copy link
Author

I'm using Rocky 9 and I'm trying to create a crossplane provider for libvirt using upjet from this libvirt terraform provider: https://registry.terraform.io/providers/dmacvicar/libvirt/latest/docs

I can't seem to get to prepare.sh script to work when I put in the provider name and organization name as inputs. I receive the sed error above saying there are no input files.

@haarchri
Copy link
Contributor

add an PR for this error: crossplane/upjet-provider-template#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:information
Projects
None yet
Development

No branches or pull requests

4 participants