Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error pointing to spec.initProvider when required parameters are not provided #273

Closed
turkenh opened this issue Sep 7, 2023 · 1 comment · Fixed by #274
Closed
Assignees
Labels
bug Something isn't working needs:triage

Comments

@turkenh
Copy link
Member

turkenh commented Sep 7, 2023

What happened?

We are getting misleading/confusing errors when we don't provide a top-level required parameter indicating as if it should have been set under spec.initProvider.

See related discussion: crossplane-contrib/provider-upjet-azure#535 (comment)

How can we reproduce it?

Trying to create the following manifest:

apiVersion: eventhub.azure.upbound.io/v1beta1
kind: EventHub
metadata:
  name: example-eventhub
spec:
  forProvider: {}

Fails with:

The EventHub "example-eventhub" is invalid:
* spec: Invalid value: "object": no such key: initProvider evaluating rule: messageRetention is a required parameter
* spec: Invalid value: "object": no such key: initProvider evaluating rule: partitionCount is a required parameter
@lsviben
Copy link
Contributor

lsviben commented Sep 7, 2023

This should fix it: #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants