Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrator: It's impossible to delete old MR without remove k8s finalizer #292

Closed
haooliveira84 opened this issue Oct 25, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@haooliveira84
Copy link

What happened?

After execution migration from contrib-provider, in the delete old MR step, it's impossible to delete old MR without removing the k8s finalizer

How can we reproduce it?

Execute the migrator on the automatic way

@haooliveira84 haooliveira84 added the bug Something isn't working label Oct 25, 2023
@stevendborrelli stevendborrelli self-assigned this Oct 30, 2023
@stevendborrelli
Copy link

I have been able to replicate this behavior. I'll see if I can figure the issue out.

@stevendborrelli
Copy link

This was fixed in upjet via PR #272, however later changes in Crossplane runtime cause builds of the migrator to fail.

This version of crossplane-runtime contains the fix before API changes were made: github.com/crossplane/crossplane-runtime v1.14.0-rc.0.0.20231011070344-cc691421c2e5

@haooliveira84
Copy link
Author

Thanks @stevendborrelli I'll close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants