Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_kms_key_* example *.yaml not generated #74

Closed
Piotr1215 opened this issue Aug 19, 2022 · 1 comment
Closed

google_kms_key_* example *.yaml not generated #74

Piotr1215 opened this issue Aug 19, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Piotr1215
Copy link

Piotr1215 commented Aug 19, 2022

What happened?

Following KMS resources

  • google_kms_key_ring_import_job
  • google_kms_key_ring_iam_member
  • google_kms_crypto_key_iam_member

had no example *.yaml files automatically generated.
The resources are not on skipList and TF Provider version match. The configuration is correct and example files were generated manually.
What other reasons could there be for it not to generate an example file?

How can we reproduce it?

  1. Configure the resource
  2. Run make generate or make reviewable

Expected behaviour

Examples file are generated in the example-generated/kms folder.

Actual behaviour

Files are not generated. No error in the make run output.

PR to help reproduce the issue: https://github.com/upbound/official-providers/pull/577

@Piotr1215 Piotr1215 added the bug Something isn't working label Aug 19, 2022
@Piotr1215 Piotr1215 changed the title google_kms_key_ring_import_job example not generated google_kms_key_ring_import_job, google_kms_key_ring_iam_member example not generated Aug 22, 2022
@Piotr1215 Piotr1215 changed the title google_kms_key_ring_import_job, google_kms_key_ring_iam_member example not generated google_kms_key_* example *.yaml not generated Aug 22, 2022
@turkenf
Copy link
Collaborator

turkenf commented Sep 21, 2023

Since we now have the specified resources we can close this issue.

@turkenf turkenf closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants