Add new guide about adding a new resource #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenf
force-pushed
the
add-resource-guide
branch
4 times, most recently
from
bfa322d
to
8176466
Compare
turkenf
requested review from
ulucinar,
sergenyalcin,
erhancagirici and
mergenci
as code owners
3 tasks
There was a problem hiding this comment.
Thanks @turkenf for this detailed guide. This is very helpful. I left a few comments in the first pass.
Signed-off-by: Fatih Türken <[email protected]>
turkenf
force-pushed
the
add-resource-guide
branch
from
8176466
to
de9edae
Compare
mergenci
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
@turkenf, Thanks for writing this essential guide. Even I, as a maintainer, learned from it.
I can't help but notice that PR review workflow suits badly to documentation writing — especially for new and large documents like this one. If you prefer, I would be happy to address my comments below in a separate PR. None of them are must-have anyways.
Signed-off-by: Fatih Türken <[email protected]>
jeanduplessis
approved these changes
Jul 2, 2024
displague
added a commit
to displague/upjet
that referenced
this pull request
Aug 28, 2024
3 tasks
displague
added a commit
to displague/upjet
that referenced
this pull request
Aug 28, 2024
Follow-up to crossplane#405 Signed-off-by: Marques Johansson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a new guide about adding a new resource.
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.