Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

'version' is a mandatory parameter in xwalk_apkgen, should probably be optional #53

Open
baleboy opened this issue Mar 23, 2014 · 2 comments

Comments

@baleboy
Copy link

baleboy commented Mar 23, 2014

After installing crosswalk-apk-generator with npm, the "xwalk_apkgen" command example here:

https://www.npmjs.org/package/crosswalk-apk-generator

fails because the 'version' field is missing though it seems to be mandatory. It would be better if it were optional (as in make_apk)

xwalk_apkgen --androidSDKDir
--xwalkAndroidDir
--appRoot
--appLocalPath


--name
--package
--outDir

@baleboy baleboy changed the title NPM documentation doesn't mention that 'version' is mandatory 'version' is a mandatory parameter in xwalk_apkgen, should probably be optional Mar 23, 2014
@townxelliot
Copy link
Contributor

If it's optional, what should we do in the manifest? Not set the version field at all or set it to a default? (Not setting it would make it difficult for the resulting package to be updated.)

@baleboy
Copy link
Author

baleboy commented Mar 24, 2014

I don't know :) I just noticed it was optional in make_apk so I thought the same logic could be used here. But I'm OK also mentioning in the documentation that the parameter is mandatory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants