Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise the game join mechanism #31

Open
spMohanty opened this issue Aug 16, 2018 · 0 comments
Open

Standardise the game join mechanism #31

spMohanty opened this issue Aug 16, 2018 · 0 comments

Comments

@spMohanty
Copy link
Member

spMohanty commented Aug 16, 2018

The game join actually happens on the env.reset call, and right now is very unstable.
Especially in the case, when a previous episode was interrupted because of un expected reasons : errors, etc.
Right now, we try to check if a game is running, and if it is, we try to send a "quit" command. But even that has been pretty buggy.

In many cases, we get the not enough clients in the client pool error.

We should standardize it properly, so that we use a consistent and a stable way to join the game.

The main considerations would be, how the behavior should be in case of a multi agent setup. My proposal would be, in case of a multi agent setup, only role0 is allowed to "force quit" a previously running game.

cc. @katja-hofmann @AndKram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant