Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for FindTheGoal #55

Open
rocanaan opened this issue Sep 21, 2018 · 5 comments
Open

Documentation for FindTheGoal #55

rocanaan opened this issue Sep 21, 2018 · 5 comments

Comments

@rocanaan
Copy link

rocanaan commented Sep 21, 2018

Hello,

I was looking at issue #32 and the documentation for the environments and realized the FindTheGoal environment is one of the few environments with no documentation.

Since this is the environment that will be used for the first phase, I would like to know if there is an ETA for the documentation on this environment to be made available.

If I may make some suggestions, I would like to know:

  • If the room is always flat or if the goal may be occluded by walls (making it somewhat like a maze)
  • What materials are possible for the goal block and for the rest of the room
  • If there might be obstacles such as lava, holes, steps, etc.

Thank you very much!

@spMohanty
Copy link
Member

spMohanty commented Sep 21, 2018

@rocanaan : You are right, there was a small issue. While I fixed it, I realised the docstirngs for FindTheGoal are not written. @idvhfd confirmed that he will be adding them soon.

And wrt your questions,

  • the room will always be flat, and goal will not be occluded by walls
  • the materials for goal block could be : gold_ore diamond_ore redstone_ore
  • there will be no obstacles.

@idvhfd : This is what needs a touch up : https://github.com/crowdAI/marLo/blob/master/marlo/envs/FindTheGoal/main.py#L12

@ludns
Copy link

ludns commented Sep 24, 2018

@spMohanty How do you configure the env to have gold_ore diamond_ore redstone_ore being chosen randomly instead of the usual gold block?

@spMohanty
Copy link
Member

spMohanty commented Sep 25, 2018

@justinglibert : Its defined here. I might be misinterpreting it.
@rdgain : Can you comment on this ?

@ludns
Copy link

ludns commented Sep 25, 2018

@spMohanty what I mean is that when I run the environment I never see any block other than the gold one. I looked at the mission file and didn't find a parameter to set that up. If during evaluation our agent can encounter non gold block, how are we supposed to set our local environment to reproduce this diversity?

idvhfd added a commit that referenced this issue Oct 2, 2018
@idvhfd
Copy link
Collaborator

idvhfd commented Oct 2, 2018

Apologies for the delay, I was unable to attend this earlier. I added a brief description in the same style as the previous ones (awaiting confirm and pull). Thanks for pointing this out and please do accept my apologies for creating this situation. Let me know if anything else like this is needed.

@justinglibert the seed is being passed as a parameter, that's where the block comes from. Waiting on @spMohanty for exact path to that bit as I can't look for it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants