Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Switching Character mid map added negative time to total #481

Open
Rogerdin13 opened this issue Jan 18, 2025 · 1 comment
Open

bug: Switching Character mid map added negative time to total #481

Rogerdin13 opened this issue Jan 18, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@Rogerdin13
Copy link

Describe the bug
When i switched characters mid map and then after map finished checked my earning i noticed that my earnings/s were negative, so i checkted the reposnse from server and saw that timeEffort was negative (see screenshot).
This time effort is also deducted/added to the total playtime of a character, not sure if computations are still correct but they seem to be.

IMO 2 possible solutions:

  1. QUICKFIX: use positive value for computations instead in webUI
  2. FULLFIX: fix underlying issue in server/game-logic to computatuions are correct throughout all computations

To Reproduce

  1. Have min. 2 characters.
  2. Join charcter play 1-2 rounds
  3. Switch characters on website
  4. Rejoin server
  5. Get earning/play a round
  6. Time effort in server response is negatvie therefore computations break heavily:

Image
// really high /s value since time was deducted from total :/

Expected behavior
Time-Effort shouldnt be negative and correct (havent tested with realtime yet)

Screenshots/Videos
Image

Context

  • cRPG version .115
@Rogerdin13 Rogerdin13 added the bug Something isn't working label Jan 18, 2025
@Rogerdin13
Copy link
Author

Rogerdin13 commented Jan 18, 2025

IMO a quick merge of 1) should be done since it feels precice computations are a big must have currently to compare efforts between modes

  1. solution: timeEffort = timeEffort < 0 ? -timeEffort : timeEffort
  2. i need to know how i can run my own test server with test versions or if i can use some of yours? need some help hear definetly

@or2e @Muparadzi

@Rogerdin13 Rogerdin13 changed the title Switching Character mid map added negative time to total bug: Switching Character mid map added negative time to total Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant