Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues, tidy code #75

Closed
wants to merge 14 commits into from
Closed

Fix issues, tidy code #75

wants to merge 14 commits into from

Conversation

Jacky720
Copy link
Contributor

@Jacky720 Jacky720 commented Nov 5, 2021

User changes:

  • Resolve Add dimensional box inventories #11: Boxes added in new row between Snowdin values, Hotland values, and fun values.
  • Resolve Keychain #34: All obtainable keys (except the Mystery Key of course) added between Cellphone and Other.
  • Resolve Omega Flowey problems #74: Option to download file8 (necessary for post-Photoshop Flowey) added when trapped in Flowey's World. Not currently documented in help.html.

Code changes:

  • Use iniIDs array for writing ini values to JS object (not currently used for printing to the interface).
  • Use flagFor and flags arrays to automatically populate stateChoiceArrays, saving redundant information such as the Toriel and Lesser Dog states.
  • Use flagFor array for printing save values to the interface rather than repeatedly calling updateSelection.

KockaAdmiralac
KockaAdmiralac reviewed Nov 6, 2021
View reviewed changes
main.js Outdated Show resolved Hide resolved
@Jacky720
var -> let and const
f3daede 
And use 'this', and define Blobs inline, and document uneditable values (of which there are like four). Oh, and use ternaries with those checkbox values so that we don't get random Number values in the middle of the save file.
@Jacky720
correct offset in exporting flags
9753395 
whoops
@Jacky720
[m] keep save file type
ec2f694 
whoops x(like 5 or something that's a code moment)
@Jacky720 Jacky720 marked this pull request as draft November 15, 2021 23:07
@Jacky720 Jacky720 marked this pull request as ready for review November 24, 2021 01:52
@Jacky720
Copy link
Contributor Author

Jacky720 commented Mar 1, 2022

I'm going to switch around some branches to update https://jacky720.github.io/FloweysTimeMachine/. And close this PR for now.

@Jacky720 Jacky720 closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KockaAdmiralac KockaAdmiralac KockaAdmiralac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Omega Flowey problems Keychain Add dimensional box inventories
2 participants
@Jacky720 @KockaAdmiralac