Crash on bond creation

[cryos]

Version is 1.0.1

Reproduce:

1. Build->Insert->Insert SMILES
2. Insert "O"
3. Select one bond, Edit->Remove
4. Switch to Draw tool, select "Hydrogen" as atom
5. Click on Oxygen atom and drag to the H atom which bond has just been deleted
6. Release on that H atom
7. -> Crash

Backtrace:

(gdb) bt
#0 0xb7fe2424 in __kernel_vsyscall ()
#1 0xb7eaa751 in raise () from /lib/i686/cmov/libc.so.6
#2 0xb7eadb82 in abort () from /lib/i686/cmov/libc.so.6
#3 0xb6c2453f in gnu_cxx::verbose_terminate_handler() () from /usr/lib/libstdc++.so.6
#4 0xb6c22405 in ?? () from /usr/lib/libstdc++.so.6
#5 0xb6c22442 in std::terminate() () from /usr/lib/libstdc++.so.6
#6 0xb6c224fb in cxa_rethrow () from /usr/lib/libstdc++.so.6
#7 0xb701c512 in QCoreApplication::notifyInternal(QObject, QEvent) () from /usr/lib/libQtCore.so.4
#8 0xb7292a52 in QApplicationPrivate::sendMouseEvent(QWidget, QMouseEvent, QWidget, QWidget, QWidget**, QPointer&, bool) () from /usr/lib/libQtGui.so.4
#9 0xb731dd7c in ?? () from /usr/lib/libQtGui.so.4
#10 0xb731d283 in QApplication::x11ProcessEvent(_XEvent*) () from /usr/lib/libQtGui.so.4
#11 0xb734b3c2 in ?? () from /usr/lib/libQtGui.so.4
#12 0xb699b305 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
#13 0xb699efe8 in ?? () from /lib/libglib-2.0.so.0
#14 0xb699f1c8 in g_main_context_iteration () from /lib/libglib-2.0.so.0
#15 0xb70480a5 in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib/libQtCore.so.4
#16 0xb734af25 in ?? () from /usr/lib/libQtGui.so.4
#17 0xb701ab19 in QEventLoop::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib/libQtCore.so.4
#18 0xb701af6a in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib/libQtCore.so.4
#19 0xb702019f in QCoreApplication::exec() () from /usr/lib/libQtCore.so.4
#20 0xb728c667 in QApplication::exec() () from /usr/lib/libQtGui.so.4
#21 0x08072763 in ?? ()
#22 0xb7e96c76 in __libc_start_main () from /lib/i686/cmov/libc.so.6
#23 0x08061741 in _start ()

Reported by: @mbanck

[cryos]

Reproduced.

Addition: if you try create new bond instead of re-draw deleted, result is the same

Original comment by: @annulen

[cryos]

Another related case: draw methane and try to attach one more H to C

Original comment by: @annulen

[cryos]

Partial fix submitted to Gerrit, but now crashes after Undo

Original comment by: @annulen

[cryos]

http://review.source.kitware.com/805 is an attempt to fix the test crash introduced with this commit.

Original comment by: @cryos