fix(recording): backwards compatibility for restart parameter

[tthvo]

Welcome to Cryostat! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

---

Fixes: #1670

Description of the change:

Added back the restart parameter for backwards compatibility. Future major releases can remove it if needed but should highlight this.

Motivation for the change:

See #1670

I recall we had some discussion around this change before but I can't remember exactly what we landed on. Since this is changing in a minor release version the API "shouldn't" change in incompatible ways, but I'm okay with changing a query parameter like this. Or we could have the endpoint handler handle both forms and prefer the newer one if both are supplied.

How to manually test:

The old legacy graphQL query with restart parameter should work fine:

query {
    environmentNodes(filter: { name: "JDP" }) {
        descendantTargets {
            doStartRecording(recording: {
                name: "foo",
                template: "Profiling",
                templateType: "TARGET",
                duration: 30,
                restart: true
                }) {
                    name
                    state
            }
        }
    }
}

Also, operations on web client also succeeds.

[github-actions]

Hi @tthvo! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

[tthvo]

/build_test

[tthvo]

https://github.com/cryostatio/cryostat/actions/runs/6219769657

[github-actions]

ARCH	IMAGE
amd64	ghcr.io/cryostatio/cryostat:pr-1672-5b505813a11384658f61e0d2d9dad07b6f19f49a-linux-amd64
arm64	ghcr.io/cryostatio/cryostat:pr-1672-5b505813a11384658f61e0d2d9dad07b6f19f49a-linux-arm64

To run smoketest:

# amd64          
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1672-5b505813a11384658f61e0d2d9dad07b6f19f49a-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1672-5b505813a11384658f61e0d2d9dad07b6f19f49a-linux-arm64 sh smoketest.sh

[andrewazores]

Thanks @tthvo !