Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rules): remove unused code #1677

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #416

Description of the change:

Cleans up unused code.

Motivation for the change:

An early draft of the Automated Rules implementation actually had the Cryostat server use a Vert.x WebClient instance to make API requests to itself for actions like starting recordings. This approach was abandoned, but some of the scaffolding for it got left behind.

@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Sep 20, 2023
@github-actions
Copy link
Contributor

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@mergify mergify bot added the safe-to-test label Sep 20, 2023
@andrewazores
Copy link
Member Author

/build_test

@andrewazores
Copy link
Member Author

@andrewazores
Copy link
Member Author

/build_test

@andrewazores
Copy link
Member Author

@github-actions
Copy link
Contributor

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1677-ba12a101acbe17282e3ee3ac4c35413fd532950e-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1677-ba12a101acbe17282e3ee3ac4c35413fd532950e-linux-arm64

To run smoketest:

# amd64          
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1677-ba12a101acbe17282e3ee3ac4c35413fd532950e-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1677-ba12a101acbe17282e3ee3ac4c35413fd532950e-linux-arm64 sh smoketest.sh

Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@andrewazores andrewazores merged commit 1d9219b into cryostatio:main Sep 20, 2023
7 checks passed
@andrewazores andrewazores deleted the rules-http-cleanup branch September 20, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants