Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(client-assets): update test for relative app bundle location #1830

Merged
merged 2 commits into from
Dec 11, 2023
Merged

test(client-assets): update test for relative app bundle location #1830

merged 2 commits into from
Dec 11, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to #1810

@github-actions GitHub Actions
Copy link
Contributor

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link
Contributor

Workflow started at 12/11/2023, 1:35:31 PM. View Actions Run.

@github-actions GitHub Actions
Copy link
Contributor

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1830-d5879ee85fed7ab3a939cc40ec22446d5f913607-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1830-d5879ee85fed7ab3a939cc40ec22446d5f913607-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1830-d5879ee85fed7ab3a939cc40ec22446d5f913607-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1830-d5879ee85fed7ab3a939cc40ec22446d5f913607-linux-arm64 sh smoketest.sh

@github-actions GitHub Actions
Copy link
Contributor

/build_test : At least one test failed ❌.
View Actions Run.

@andrewazores andrewazores merged commit 1e2efda into main Dec 11, 2023
14 of 15 checks passed
@andrewazores andrewazores deleted the relative-href-itest branch December 11, 2023 19:04
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@andrewazores @mergify
test(client-assets): update test for relative app bundle location (#1830
2c24b06 
)

* test(client-assets): update test for relative app bundle location

* add test for relative base href

(cherry picked from commit 1e2efda)
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
@andrewazores andrewazores mentioned this pull request Dec 11, 2023
Merged
7 tasks
andrewazores added a commit that referenced this pull request Dec 11, 2023
@mergify @andrewazores
test(client-assets): update test for relative app bundle location (#1830
ff1f555 
) (#1831)

* test(client-assets): update test for relative app bundle location

* add test for relative base href

(cherry picked from commit 1e2efda)

Co-authored-by: Andrew Azores <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport safe-to-test test
Projects
No open projects
2.4.1 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewazores