Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unused resources can be left over on operator upgrade #975

Open
andrewazores opened this issue Nov 25, 2024 · 0 comments
Open

[Bug] Unused resources can be left over on operator upgrade #975

andrewazores opened this issue Nov 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

          > I noticed one other funny effect from the https://github.com/cryostatio/cryostat-operator/pull/897 upgrade steps - the old separate Grafana Route gets left behind. That makes sense since it was an upgrade from 2.4.0 to 4.0.0-dev, and in 2.x we exposed Grafana as a separate Route. In 3.0 it's exposed as a path on the auth proxy with the same Route. I think the old leftover Route is harmless, but also useless.

Oh right, how about we delete the old Grafana route in the reconciler, similar to how we do it for CORS modifications?

// Remove CORS modifications from previous operator versions
return r.deleteCorsAllowedOrigins(ctx, cr)

Originally posted by @tthvo in #968 (comment)

@andrewazores andrewazores added the bug Something isn't working label Nov 25, 2024
@andrewazores andrewazores moved this to Backlog in 4.0.0 release Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant