Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Order and convention for css rules #853

Open
tthvo opened this issue Feb 3, 2023 · 0 comments
Open

[Task] Order and convention for css rules #853

tthvo opened this issue Feb 3, 2023 · 0 comments
Labels
chore Refactor, rename, cleanup, etc. good first issue Good for newcomers needs-triage Needs thorough attention from code reviewers

Comments

@tthvo
Copy link
Member

tthvo commented Feb 3, 2023

Describe the feature

As our application grows, many more css rules are being added. I think it would be best to have a way to break the large app.css down. Also, we need some convention established. For example, name should start with cryostat-* and follow BEM convention.

Any other information?

Some useful source: https://www.freecodecamp.org/news/css-naming-conventions-that-will-save-you-hours-of-debugging-35cea737d849/
@tthvo tthvo added chore Refactor, rename, cleanup, etc. needs-triage Needs thorough attention from code reviewers good first issue Good for newcomers labels Feb 3, 2023
@tthvo tthvo mentioned this issue Sep 27, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. good first issue Good for newcomers needs-triage Needs thorough attention from code reviewers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tthvo