fix(eventtemplates): log warning and continue if declarative Event Te…

…mplate already exists (#726)
cryostatio · Nov 28, 2024 · a141072 · a141072
1 parent c3ee63b
commit a141072
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/main/java/io/cryostat/events/S3TemplateService.java b/src/main/java/io/cryostat/events/S3TemplateService.java
@@ -115,6 +115,8 @@ void onStart(@Observes StartupEvent evt) {
                                         | InvalidXmlException
                                         | InvalidEventTemplateException e) {
                                     logger.error(e);
+                                } catch (IllegalArgumentException e) {
+                                    logger.warn(e);
                                 }
                             });
         } catch (IOException e) {
@@ -225,8 +227,7 @@ public Template addTemplate(InputStream stream)
             var template = createTemplate(model);
             var existing = getTemplates();
             if (existing.stream().anyMatch(t -> Objects.equals(t.getName(), template.getName()))) {
-                throw new IllegalArgumentException(
-                        String.format("Duplicate event template name: %s", template.getName()));
+                throw new DuplicateTemplateException(template.getName());
             }
             storage.putObject(
                     PutObjectRequest.builder()
@@ -357,4 +358,10 @@ private String getAttributeValue(XMLTagInstance node, String valueKey) {
                 .findFirst()
                 .get();
     }
+
+    static class DuplicateTemplateException extends IllegalArgumentException {
+        DuplicateTemplateException(String templateName) {
+            super(String.format("Event Template with name \"%s\" already exists", templateName));
+        }
+    }
 }