chore(db): apply active record validation constraints #257
Conversation
|
/build_test |
|
Workflow started at 1/22/2024, 2:29:45 PM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
1 similar comment
|
CI build and push: All tests pass ✅ |
andrewazores
force-pushed
the
activerecord-validations
branch
from
ff121fe to
27fa381
Compare
|
/build_test |
|
Workflow started at 1/22/2024, 3:36:54 PM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
1 similar comment
|
CI build and push: All tests pass ✅ |
|
/build_test |
|
Workflow started at 1/22/2024, 5:33:18 PM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
1 similar comment
|
CI build and push: All tests pass ✅ |
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #256
Fixes #259
How to manually test (JPA validation changes):
NotNull/NotBlank/etc. changes should be mostly invisible in normal operation, since the UI and the API layer already perform checks and validations on these things so that nice UI messages can be displayed to the user as hints before submitting requests, or so that the server can return informative error messages on bad requests that do come through. Applying these checks at the persistence layer is the last line of defense to ensure that invalid data is not entered into the database.@JsonPropertyetc. changes ensure that particular fields do not get read or written when they should not be. For example, on Credential, they ensure that if we make a mistake and write out a Credential object through the API layer, the username and password are not actually sent out to the client../mvnw clean verify ; podman image prune -f./smoketest.bash -OgtrHow to manually test (Discovery tree changes):
./mvnw clean verify ; podman image prune -f./smoketest.bash -Ogtrand wait some time for startup to complete and agents to registerhttp --auth=user:pass :8080/api/v3/targetsand ensure all targets, including Cryostat Agent instances, appearhttp --auth=user:pass :8080/api/v3/discoveryand ensure all targets, including Cryostat Agent instances, appear