Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(smoketest): re-add environment variables for presigned downloads secrets #267

Merged
merged 1 commit into from
Jan 25, 2024
Merged

test(smoketest): re-add environment variables for presigned downloads secrets #267

merged 1 commit into from
Jan 25, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #266
See #241 (partial revert)

How to manually test:

  1. ./smoketest.bash
  2. Go to Recordings
  3. Select Cryostat localhost:0 as the target
  4. Try to download one of the active recordings

@andrewazores andrewazores changed the title fix(smoketest): re-add environment variables for presigned downloads secrets test(smoketest): re-add environment variables for presigned downloads secrets Jan 24, 2024
@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 1/24/2024, 10:46:58 AM. View Actions Run.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7642683104

1 similar comment
@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7642683104

@andrewazores andrewazores force-pushed the smoketest-recording-download branch from 5a6b8d5 to 2ee1176 Compare January 25, 2024 15:48
@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 1/25/2024, 10:49:20 AM. View Actions Run.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7657009028

1 similar comment
@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7657009028

@andrewazores
Copy link
Member Author

@aali309 @mwangggg ping

This was referenced Jan 25, 2024
Draft
Merged
aali309
aali309 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit f459563 into cryostatio:main Jan 25, 2024
8 checks passed
@andrewazores andrewazores deleted the smoketest-recording-download branch January 25, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aali309 aali309 aali309 approved these changes

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
safe-to-test test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Recording download failure
2 participants
@andrewazores @aali309