Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] JVM ID failure on discovery is no longer tolerated #390

Closed
andrewazores opened this issue Apr 18, 2024 · 1 comment · Fixed by #391
Closed

[Bug] JVM ID failure on discovery is no longer tolerated #390

andrewazores opened this issue Apr 18, 2024 · 1 comment · Fixed by #391
Assignees
@andrewazores
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

Current Behavior

#329 - the changes from this PR no longer seem to work. Targets whose JVM IDs can't be discovered immediately at discovery no longer appear in the discovery listing.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Anything else?

No response
@andrewazores andrewazores added the bug Something isn't working label Apr 18, 2024
@andrewazores andrewazores self-assigned this Apr 18, 2024
@andrewazores
Copy link
Member Author

Bisect shows broken by #294.

@andrewazores andrewazores mentioned this issue Apr 18, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewazores andrewazores

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(discovery): do not require nonnull jvmIds for websocket notifications andrewazores/cryostat3
1 participant
@andrewazores